Fortsätt till huvudinnehåll

Embedded development questions part II

I present to you, this piece of code:

bool keyPressed = false;

void interruptServiceRoutine()
{
  keyPressed = true;
}

int main()
{
  for (;;)
  {
    while (!keyPressed);
    std::cout << "A key was pressed!";
  }
  return 0;
}

Take a minute to think about what's wrong with the code above.
Ready? Ok, here are the things I came to think of during my job interview.

  1. keyPressed is set to true in the ISR. But never (re)set to false anywhere.
  2. keyPressed should be volatile to ensure the compiler does not optimize it.
  3. There is a risk for key bounce which may result in several interrupts per key press.
To solve 1 and 2 the code can be modified to look like this:

volatile bool keyPressed = false;

void interruptServiceRoutine()
{
  keyPressed = true;
}

int main()
{
  for (;;)
  {
    while (!keyPressed);
    std::cout << "A key was pressed!";
    keyPressed = false;
  }
  return 0;
}

In order to tackle 3, delays can be inserted. These are called debouncing periods and usually about 10 ms is enough. Note that key bounces can occur both when the key is pressed and when it is released.
I'll leave it to you to figure out where to insert the debouncing periods.
Etiketter:

Kommentarer

Skicka en kommentar

Populära inlägg i den här bloggen

C# Enum as bit field

Bit field enum Whenever you wish to express combinations of properties of an object, bit fields are a good way to accomplish this. As a simple example, consider a file in the file system. It can be Readable , Writable , Hidden or a combination these. The different attributes can be defined as an enum : [Flags] public enum FileAttribute {   None      = 0b0000;   Readable  = 0b0001;   Writeable = 0b0010;   Hidden    = 0b0100; } To indicate that this enum is expected to be used as a bit field I have defined it with the FlagsAttribute . It is important to understand that the FlagsAttribute does nothing more than making some changes to how the ToString method of the enum works, making it possible to print out all flags. It does not introduce any validation or special treatment of the enum in any other way. I have defined the values of the different fields of the enum using binary representation, this should make it even more clear that this is a bit field and which bi
Skicka en kommentar
Läs mer

Codility tasks - Part I

I was recently faced with two codility tasks when applying for a job as an Embedded Software Engineer. For those of you who arn't familiar with Codility you can check out their website here:  www.codility.com Task one - Dominator The first task was called Dominator. The goal was to, given a std::vector of integers, find an integer that occurs in more than half of the positions in the vector. If no dominator was found -1 should be returned. My approach was to loop through the vector from the first to the last element, using a std::map to count the number of occurences of each integer. If the count ever reached above half the size of the vector I stopped and returned that integer and if I reached the end without finding a dominator I returned -1. So was that a good approach? Well, the reviewer at the company rated the solution as 'pretty ok'. His preferred solution was store the first integer in the array and set a counter to 1. Then loop through the remaining i
7 kommentarer
Läs mer